Inserting a node in tree

gaurav133232

Iam inserting a node in the tree, while inserting , after n = 1, no further allocation is being done rather the previously allocated nodes are getting overwritten.

Below is the code:-

#include"headers.h"
#include"dataStruct.h"
#include"declarations.h"
void** insertNode(void** args)
{
//int i,n;
int n;
Node **tree;
printf("%s:Begin.\n",__func__);
tree = (Node**)args;
*(tree+0) = (Node*)(*fnptr[1])(0);
for(i = n = 1;i<2*n+1;i++,n++)
{
    /*if(*(tree+i) == NULL)
    {
      *(tree+i) = *(tree+0);
      *(tree+0) = NULL;
    }*/
    printf("i:%d\n",i);
    printf("2i:%p\n",*(tree+2*i));
    printf("2i+1:%p\n",*((tree+2*i)+1));
    if(*(tree+2*i) == NULL)
    {
      *(tree+2*i) = *(tree+0);
      *(tree+0) = NULL;
      printf("%s:Value(2i->%d)->%3d\n",__func__,2*i,(tree[2*i])->value);
      break;
    }
    else if(*(tree+(2*i+1)) == NULL)
    {
      *(tree+(2*i+1)) = *(tree+0);
      *(tree+0) = NULL;
      printf("%s:Value(2*i+1->%d)->%3d\n",__func__,(2*i+1),(tree[2*i+1])->value);
      break;
    }
    else
    {
      tree = (Node**)realloc(tree,sizeof(Node*)*(2*i+1));
      //tree = (Node**)realloc(tree,sizeof(Node*)*(2));
        if(!tree)
        {
          perror("realloc");
          (*fnptr[0])((void*)"failure");
        }
      printf("%s:Value(2i->%d)->%3d\n",__func__,2*i,tree[2*i]->value);
      printf("%s:Value(2i+1->%d)->%3d\n",__func__,2*i+1,(tree[2*i+1])->value);
      memset(tree,'\0',sizeof(Node*)*(2*i+1));
      break;
    }
}

printf("%s:End.\n",__func__);
return args;
}

your advice would be of great help.

mohdmohsinkhanee

Hey! Your code has an issue in the line:

tree = (Node**)realloc(tree, sizeof(Node*) * (2 * i + 1));

Since, for i=1, once indexes of the 1-D array (for index no 2 and 3) are filled and control goes into the else part, you are doing (2 * i + 1) = 3. This means you are not expanding your array further but re-allocating memory for already allocated nodes. If I understand correctly, you want to dynamically resize the array to accommodate more nodes. Please check on the same.

Moreover, you are also not using the memset operation correctly.

Inserting a node in tree

Howdy, Stranger!

Categories